Extend Configurables to include a startup file#560
Conversation
Codecov Report
@@ Coverage Diff @@
## master #560 +/- ##
==========================================
+ Coverage 95.10% 95.16% +0.06%
==========================================
Files 92 92
Lines 4168 4222 +54
Branches 269 271 +2
==========================================
+ Hits 3964 4018 +54
Misses 144 144
Partials 60 60
Continue to review full report at Codecov.
|
flongford
left a comment
There was a problem hiding this comment.
Thanks @robertopreste! This generally looks good, I just have some comments about variable names since ideally we don't want to refer to any specific application (i.e. ParaView) in the framework itself.
Obviously, the ParaView application is currently the only image that can make use of this feature, but in theory any other app image could also use the SRDATA environmental variable to refer to a startup data file.
Also, I now remember that we previously discussed how an admin user may like to configure the environmental variable name itself (i.e. use $MY_APP_DATA instead of $SRDATA). For the time being I think we can just use a fixed variable name for all applications, though it would be nice to keep in mind that we may want to extend this in future.
flongford
left a comment
There was a problem hiding this comment.
Couple of nits, otherwise LGTM!
Right, thanks for catching these points, I totally overlooked them! |
Closes #555
This PR adds a new Configurable,
ParaviewData, that can exploit theSRDATAenv variable exposed by Paraview-S-R to open a specific file when ParaView starts up.The Admin user can set a policy where this functionality is enabled, in which case the User will be shown a "Startup file" text input in the main view, where the path to a startup file can be provided. Currently, the only functional path is
/ParaView/can.ex2, which is an example file included in the ParaView Docker image.